Fix LightmapGI not being correctly applied to objects#111125
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Oct 6, 2025
Merged
Fix LightmapGI not being correctly applied to objects#111125akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
BlueCube3310
added
the
cherrypick:4.5
Contributor
|
Whoops, I guess I was too focused on whether the mask was correct or not. The fix seems good to me. The issue is not necessarily just because the bits are being put into a |
Member
|
I am not able review this but maybe someone the rendering team can look. It’s a regression |
clayjohn
approved these changes
Oct 6, 2025
Member
|
Thanks! |
Contributor
|
Cherry-picked to 4.5 |
Repiteo
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111123
Adds a bitshift to make the sorting key's value align with the render element's data.