X Tutup
Skip to content

Suppress SIGPIPE when writing to a pipe.#111114

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:sigpipe_ign
Nov 25, 2025
Merged

Suppress SIGPIPE when writing to a pipe.#111114
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:sigpipe_ign

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 1, 2025

Fixes #111110

Note: Not sure if this signal might be used for something else, or we could just do signal(SIGPIPE, SIG_IGN); on start and ignore it completely.

@bruvzg bruvzg added this to the 4.6 milestone Oct 1, 2025
@bruvzg bruvzg requested a review from a team as a code owner October 1, 2025 11:47
@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 17, 2025
@Repiteo Repiteo merged commit 0da802c into godotengine:master Nov 25, 2025
38 of 40 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 25, 2025

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 8, 2026
Myran added a commit to Myran/godot that referenced this pull request Feb 22, 2026
Add signal(SIGPIPE, SIG_IGN) in OS_Unix::initialize_core() to prevent
broken pipe signals from killing the process during headless exports
when stdout is piped through commands that close their read end early.

Upstream Godot PR godotengine#111114 partially fixed this for FileAccessUnixPipe
only — this covers StdLogger::logv() and all other write paths.

See: godotengine#111110
Closes: task-634

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writing to a closed pipe crashes the engine (no SIGPIPE handling)

3 participants

X Tutup