X Tutup
Skip to content

[TextServer] Enforce zero width spaces and joiners to actually be zero width and not fallback to regular space.#111014

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:lbl_sp_x
Oct 1, 2025
Merged

[TextServer] Enforce zero width spaces and joiners to actually be zero width and not fallback to regular space.#111014
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:lbl_sp_x

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 28, 2025

Fixes #110554

@bruvzg bruvzg added this to the 4.6 milestone Sep 28, 2025
@bruvzg bruvzg requested a review from a team as a code owner September 28, 2025 21:54
@bruvzg bruvzg added bug regression topic:gui cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 28, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

I've also tested the Fallback text server and the issue is also fixed there (while it happened in master), even though this only changes code in TextServerAdvanced. I find this curious…

I've tried both changing the project setting and --text-driver "Fallback (Built-in)", which is confirmed by --verbose to select the fallback text driver when enabled at compile-time.

@Repiteo Repiteo merged commit 7aa229c into godotengine:master Oct 1, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 1, 2025

Thanks!

@Repiteo
Copy link
Contributor

Repiteo commented Oct 6, 2025

Cherry-picked to 4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Labels with custom font adds an empty character to the end of line

3 participants

X Tutup