X Tutup
Skip to content

Move file filter when filesystem dock is in the bottom panel#111000

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
DallasHuff:move-file-filter
Oct 21, 2025
Merged

Move file filter when filesystem dock is in the bottom panel#111000
Repiteo merged 1 commit intogodotengine:masterfrom
DallasHuff:move-file-filter

Conversation

@DallasHuff
Copy link
Contributor

@DallasHuff DallasHuff commented Sep 28, 2025

There is extra room next to the current folder LineEdit when the filesystem dock is docked in the bottom panel.

This change moves the file filter LineEdit to be horizontal with the current folder more effectively uses the vertical space of the bottom panel.

Closes godotengine/godot-proposals#12579

Before changes:
image

After changes:
image

Docking on the side is unchanged:
image

@DallasHuff DallasHuff requested a review from a team September 28, 2025 13:31
@KoBeWi KoBeWi added this to the 4.x milestone Sep 28, 2025
@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Sep 28, 2025
@DallasHuff
Copy link
Contributor Author

DallasHuff commented Oct 6, 2025

Fixed merge conflicts. Also working on fixing an issue where some display modes show two file filters

@DallasHuff
Copy link
Contributor Author

Still working on some changes to different display modes.

I think it makes sense for vertical split display mode while the dock is in the bottom panel to be unchanged. The other display modes while the filesystem dock is in the bottom panel should have the proposed change of moving the file filter to be horizontal to the current path LineEdit (and the dock should be unchanged while the dock is docked on a side panel)

@KoBeWi
Copy link
Member

KoBeWi commented Oct 14, 2025

That's not really related to this PR, no?
btw you should squash the commits.

When the Filesystem Dock is on the bottom panel vertical space is more
valuable than horizontal space. Moving the file filter to be horizontal
with the current path LineEdit makes the dock more space efficient when
on the bottom panel. When docked on the side, the file filter is
unchanged.
@DallasHuff
Copy link
Contributor Author

Since this PR is about moving the file filter, I think it could make sense to add to the PR a case where the file filter shouldn't be moved. But I'll just leave it as is on this PR.

@Repiteo Repiteo merged commit b360196 into godotengine:master Oct 21, 2025
19 of 20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorganize the bottom dock version of the filesystem dock to save some vertical space

3 participants

X Tutup