Fix snap Polygon2D editor#110989
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 21, 2025
Merged
Conversation
|
@AThousandShips hey i am beginner in this . So sorry if mistakes made , but my question is that how to know if i should review this pr , as in many pr you have added the pr to a milestone , so should i review them and provide results , and i though of pr review before contributing it seems easier . |
Member
|
Any review you want to contribute would be welcome but please focus on functionality and not style etc. |
KoBeWi
approved these changes
Oct 17, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
When we drag a vertex of a Polygon from polygon editor.
drag_fromdrag_to, depending ongrid snapconfiguration, we will calculate withsnap_point()to let mouse position snap to the griddrag_to - drag_fromas distance to update points of polygon, that caused very hard to drag a vertex to snap the grid correctly. It should use snapped mouse position directly.e.g.