Make extended SkeletonModifiers retrieve interpolated global transform#110987
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 1, 2025
Merged
Make extended SkeletonModifiers retrieve interpolated global transform#110987Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
TokageItLab
added
topic:animation
topic:3d
cherrypick:4.5
lawnjelly
approved these changes
Sep 28, 2025
Member
lawnjelly
left a comment
lawnjelly
left a comment
There was a problem hiding this comment.
This looks fine. 👍
The only thing to be wary of here is that as a result of #107308, get_global_transform_interpolated() has the potential to be quite expensive for hidden nodes, as the calculations are done on demand.
It might be worth double checking that this code in spring_bone_simulator and look_at_modifier is turned off for hidden nodes (this is something that is often assumed but does not always happen).
Long term we may have a think whether we can try and make get_global_transform_interpolated() more idiot-proof for hidden nodes in terms of calculation on demand. It fixes a rare use case but creates significant risk of performance regressions with sloppy calling.
TokageItLab
moved this from Ready for review
to Approved, Waiting for Production
in Animation Team Issue Triage
github-project-automation
bot
moved this from Approved, Waiting for Production
to Done
in Animation Team Issue Triage
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.1. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Animatable node might have to use
get_global_transform_interpolated()instead ofget_global_transform().