X Tutup
Skip to content

Fix backward/pingpong root motion in AnimationTree#110982

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
TokageItLab:fix-rm-animtree-bw
Oct 7, 2025
Merged

Fix backward/pingpong root motion in AnimationTree#110982
akien-mga merged 1 commit intogodotengine:masterfrom
TokageItLab:fix-rm-animtree-bw

Conversation

@TokageItLab
Copy link
Member

This issue is regression by #87171. We need to retrieve not only the NodeAnimation settings but also the actual playback direction after processing. Since root motion is calculated based on the positive or negative delta in NodeTimeInfo, modifying this branch should be the correct fix.

@TokageItLab TokageItLab added this to the 4.6 milestone Sep 27, 2025
@TokageItLab TokageItLab requested a review from a team as a code owner September 27, 2025 22:37
@TokageItLab TokageItLab added bug regression topic:animation cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 27, 2025
@TokageItLab TokageItLab changed the title Fix backward root motion in AnimationTree Fix backward/pingpong root motion in AnimationTree Sep 27, 2025
@TokageItLab TokageItLab moved this to Ready for review in Animation Team Issue Triage Sep 27, 2025
@akien-mga akien-mga merged commit 1cab5e1 into godotengine:master Oct 7, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Animation Team Issue Triage Oct 7, 2025
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.5.1.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 7, 2025
@AR-DEV-1
Copy link
Contributor

This breaks the Ping-Pong animation loop in BlendTree, reported in #111719 & #111737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Root motion incorrect when playing animation by using Ping-Pong loop mode in NodeAnimation custom timeline on AnimationTree

3 participants

X Tutup