X Tutup
Skip to content

Free script and extension instance before object deconstructing#110907

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
beicause:extension-deconstruct-before-object
Sep 30, 2025
Merged

Free script and extension instance before object deconstructing#110907
Repiteo merged 1 commit intogodotengine:masterfrom
beicause:extension-deconstruct-before-object

Conversation

@beicause
Copy link
Contributor

Fixes #109762, as suggested in #109762 (comment). This seems to work in my test.

@beicause beicause requested a review from a team as a code owner September 25, 2025 18:21
@beicause beicause force-pushed the extension-deconstruct-before-object branch from efa6807 to 7631085 Compare September 25, 2025 18:54
@beicause beicause requested a review from a team as a code owner September 25, 2025 18:54
@beicause beicause force-pushed the extension-deconstruct-before-object branch 2 times, most recently from 2db51a6 to e923d0d Compare September 25, 2025 19:03
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Co-Authored-By: Lukas Tenbrink <lukas.tenbrink@gmail.com>
@beicause beicause force-pushed the extension-deconstruct-before-object branch from e923d0d to 727066f Compare September 26, 2025 10:20
@Ivorforce Ivorforce requested a review from a team September 26, 2025 12:09
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@Repiteo Repiteo merged commit 93fd5c7 into godotengine:master Sep 30, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 30, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GDExtension: Undefined behavior when calling base class methods in deconstructor

4 participants

X Tutup