X Tutup
Skip to content

Windows: Migrate godot.manifest to platform/windows, include as dependency#110897

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo:windows/migrate-manifest
Sep 30, 2025
Merged

Windows: Migrate godot.manifest to platform/windows, include as dependency#110897
Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo:windows/migrate-manifest

Conversation

@Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Sep 25, 2025

Addresses two minor issues with the current implementation of godot.manifest:

  • Migrated to platform/windows; platform-specific files should never be added to the repository root
  • Include file as Windows dependency; it was serendipity that previous revisions were accompanied by other changes, but now the file can be edited in isolation & a rebuild would trigger

• Ensure file is included as proper dependency
@Repiteo Repiteo added this to the 4.6 milestone Sep 25, 2025
@Repiteo Repiteo requested a review from bruvzg September 25, 2025 14:28
@Repiteo Repiteo requested review from a team as code owners September 25, 2025 14:28
@Repiteo Repiteo added bug platform:windows topic:buildsystem cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 25, 2025
@Repiteo Repiteo merged commit 0b2805f into godotengine:master Sep 30, 2025
20 checks passed
@Repiteo Repiteo deleted the windows/migrate-manifest branch September 30, 2025 16:26
@Repiteo
Copy link
Contributor Author

Repiteo commented Sep 30, 2025

Cherry-picked to 4.5

@Repiteo Repiteo removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 30, 2025
@Repiteo
Copy link
Contributor Author

Repiteo commented Sep 30, 2025

Cherry-picked to 4.4

@Repiteo Repiteo removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Sep 30, 2025
@Repiteo
Copy link
Contributor Author

Repiteo commented Sep 30, 2025

Cherry-picked to 4.3

@Repiteo Repiteo removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup