X Tutup
Skip to content

Fix SpinBox stepper grabbing focus state on mouse input#110894

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Giganzo:spinbox-focus-state
Oct 1, 2025
Merged

Fix SpinBox stepper grabbing focus state on mouse input#110894
Repiteo merged 1 commit intogodotengine:masterfrom
Giganzo:spinbox-focus-state

Conversation

@Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Sep 25, 2025

#110250 changed focus behavior for mouse input.

SpinBox is still showing focus when stepper is clicked with the mouse:

Screencast_20250924_164720.webm

After:

Screencast_20250924_164553.webm

@Giganzo Giganzo requested a review from a team as a code owner September 25, 2025 12:52
@AThousandShips AThousandShips added this to the 4.6 milestone Sep 26, 2025
Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Repiteo Repiteo merged commit 131d6b1 into godotengine:master Oct 1, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 1, 2025

Thanks!

@Giganzo Giganzo deleted the spinbox-focus-state branch October 2, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup