Use correct AABB for SpotLight3Ds when spot_angle > 90#110884
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 6, 2025
Merged
Use correct AABB for SpotLight3Ds when spot_angle > 90#110884Repiteo merged 1 commit intogodotengine:masterfrom
spot_angle > 90#110884Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
added
bug
topic:rendering
topic:3d
cherrypick:4.4
Calinou
reviewed
Sep 25, 2025
Calinou
reviewed
Sep 25, 2025
Calinou
reviewed
Sep 25, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally on all rendering methods, it works as expected. Code looks good to me.
Kaleb-Reid
force-pushed
the
fix-spotlight-aabb
branch
from
94e60f6 to
f42a23d
Compare
Contributor
Author
|
@Calinou I made the suggested changes. |
clayjohn
removed
the
cherrypick:4.4
clayjohn
requested changes
Oct 4, 2025
Kaleb-Reid
force-pushed
the
fix-spotlight-aabb
branch
from
f42a23d to
91167c3
Compare
akien-mga
changed the title
spot_angle > 90
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess in 4bd01a9 the AABB shown in the editor was updated for SpotLight3Ds to support large angles but the AABB actually used for culling was not.
Fixes #110367