Wayland: Inhibit idle in DisplayServerWayland::screen_set_keep_on#110875
Wayland: Inhibit idle in DisplayServerWayland::screen_set_keep_on#110875Repiteo merged 1 commit intogodotengine:masterfrom
DisplayServerWayland::screen_set_keep_on#110875Conversation
Without this, the screen does go into idle after a few minutes on a RPi5 with default install (wayland w/ labwc), even though `screen_keep_on` is set. DBUS is enabled but apparently, the screensaver call is not enough.
deralmas
left a comment
deralmas
left a comment
There was a problem hiding this comment.
Great catch! We absolutely need to also call the inhibit method for situations where there is not a suitable portal to ensure compatibility with as many compositors as possible.
I swear, there once was an inhibit call but for some mysterious reason it... Disappeared? 😅
Haven't tested but the fix is trivial.
Also, FTR, the idle inhibit protocol says that if the inhibited window is occluded the compositor will ignore it. I wonder if we should eventually apply it to every window (even new ones?) to avoid that. Eh, this will definitely do for now :D
Calinou
added
bug
platform:linuxbsd
topic:platforms
cherrypick:4.5
i was also surprised 😄 Especially as there are no calls to the
Right. i've only tested this for a single-window, fullscreen game. It would certainly make sense to do it for all windows (and new ones). Happy to do it in a new PR later. |
|
Thanks! |
akien-mga
changed the title
|
Cherry-picked for 4.5.1. |
akien-mga
removed
the
cherrypick:4.5
akien-mga
changed the title
DisplayServerWayland::screen_set_keep_on
5 participants
Without this, the screen does go into idle after a few minutes on a RPi5 with default install (wayland w/ labwc), even though
screen_keep_onis set. DBUS is enabled but apparently, the screensaver call is not enough.