X Tutup
Skip to content

Reduce repetitive code in FoldableContainer#110871

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:fold_code
Oct 21, 2025
Merged

Reduce repetitive code in FoldableContainer#110871
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:fold_code

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 24, 2025

Inspired by #110847
Adds a helper method to get title rect.

@KoBeWi KoBeWi added this to the 4.x milestone Sep 24, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner September 24, 2025 20:04
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on the Control Gallery demo, it works as expected.

Code looks good to me.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Oct 21, 2025
@Repiteo Repiteo merged commit ebe83ac into godotengine:master Oct 21, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2025

Thanks!

@KoBeWi KoBeWi deleted the fold_code branch October 21, 2025 20:31
@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
@akien-mga
Copy link
Member

Cherry-picked for 4.5.2. (Needed for #110847.)

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup