Add solo/hide/lock/delete buttons to node groups in bezier track editor#110866
Add solo/hide/lock/delete buttons to node groups in bezier track editor#110866Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
fantasic! just popping in to say that looking at the vid, the buttons appears to miss a hover effect currently. |
I would agree. That would technically also be a pre-existing issue though, since it already applies to the per-track buttons, but maybe we can throw that in there as well. |
The hover effect turned into more than just a line or two of code, due to how the drawing for these things is done, so we opted to leave it for now, so as to not make this PR any bigger than it needs to be. |
|
We need to test it and review code, but from a design perspective we discussed in the animation meeting and agree with adding icons to the node groups. |
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
From an UX perspective, I suggest fading out the icons of individual nodes a little, like we do in the input map editor for input events for each action:
Notice how the trash icon is slightly less opaque for individual events compared to the action above it. This helps distinguish long lists of icons and making sure you click the icon you actually meant to click when the icon is far away from the text.
Something like this:
| Before | After (mockup) |
|---|---|
 |
 |
Co-authored-by: Kasper Arnklit Frandsen <kasper.arnklit@gmail.com>
|
The slightly lowered opacity for the per-track icons is now in, as suggested above. I also threw in a rebase for good measure. |
TokageItLab
left a comment
TokageItLab
left a comment
There was a problem hiding this comment.
Tested, and LGTM.
During monkey testing, an error occurred only once when deleting a track, but it did not cause a crash, and I cannot reproduce it.
The application behaves stably during normal use, and the code is clean. Therefore, I judge that any issues can be adequately addressed later if they arise.
TokageItLab
moved this from Ready for review
to Approved, Waiting for Production
in Animation Team Issue Triage
github-project-automation
bot
moved this from Approved, Waiting for Production
to Done
in Animation Team Issue Triage
|
Thanks! |
6 participants
Resolves godotengine/godot-proposals#11340.
Co-authored with @Arnklit.
This adds four new buttons to the node groups found in the bezier animation track editor: solo, hide/show, lock/unlock and delete. This is basically the same as what's already found on each of the individual bezier tracks.
Here's a short clip showing what it looks like and how they behave.
BezierNodeGroupButtons.webm
Note that no per-node state has been introduced to accommodate for things like visibility or locking, so you're only ever toggling the state of the individual tracks themselves.
Unlike the proposal linked above, which mentioned that a solo button might not make sense for node groups, we felt that it did in fact make sense and could be useful, so we added that as well.
Also note that there are a couple of pre-existing issues surrounding all of this that this PR does not do anything to resolve:
We did however throw in a fix for an out-of-bounds error when deleting all bezier tracks, but the others we felt would complicate this already hefty PR too much.
We did also take the opportunity to change/fix the alignment/margins of the icons, which seemed a bit off.
Contributed by W4 Games 🍀