FoldableContainer: Override has_point to use title rect when folded#110847
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 1, 2026
Merged
FoldableContainer: Override has_point to use title rect when folded#110847akien-mga merged 1 commit intogodotengine:masterfrom
has_point to use title rect when folded#110847akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
KoBeWi
reviewed
Dec 25, 2025
has_point to use title rect when folded
5e3aaee to
fc7d6da
Compare
Member
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Member
|
Cherry-picked for 4.5.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix #110834
Issue:
FoldableContainerSolution:
Control::has_pointso that when folded, only the title rect is considered interactive. When unfloded, the defaultControllogic is used.Notes:
FoldableContainer::gui_input. This rect is being created 4 times (including my addition) across_notification,gui_inputand nowhas_point. It might be useful to cache this and update on some size change event, or at the very least refactor the logic into a helper function.