Hi all 👋 (cc. @Ivorforce )

Further to bug report #110693, which was prematurely closed, and in which it was discovered that static casting errors occur when:

1. inheriting from Object - directly or otherwise
2. but not defining an appropriate GDCLASS or GDSOFTCLASS at each child class

And notwithstanding that my previous PR's (#110694 and #110752) fixed part of the problem, by fixing direct children of Object. Please note that this is not - however - sufficient, since there can be children deeper in the inheritance tree that will still exhibit this bug.

This PR seeks to locate all those remaining - deeper in the inheritance tree from Object - and fix them by adding an appropriate GDSOFTCLASS.

Changes

• GDSOFTCLASS added to many classes
• override keywords added to public methods in:
  • editor/export/gdextension_export_plugin.h
  • modules/multiplayer/multiplayer_debugger.h
  • platform/android/net_socket_android.h

How to validate

1. install ripgrep
2. Use (check first!) this script

#!/bin/bash

# List of parent classes (derived from the PR)
classes=(
    Object
	ResourceFormatLoader
	ResourceFormatSaver
	EngineProfiler
	RefCounted
	RemoteDebuggerPeer
	HTTPClient
	NetSocket
	EditorDebuggerServer
	CodeSignBlob
	EditorExportPlugin
	ShaderBakerExportPluginPlatform
	NetSocketUnix
	PhysicsServer2D
	PhysicsServer3D
	RenderingDeviceCommons
	RenderingServer
    NavMeshGenerator2D
    NavMeshGenerator3D
    BetsyCompressor
)

for cls in "${classes[@]}"; do
	echo "Searching for classes derived from $cls..."
	rg --pcre2 -n -H -o --multiline --multiline-dotall \
	  "^(class\s+(\w+)\s*:\s*public\s+$cls\s*\{(?:(?!GDCLASS|GDSOFTCLASS).)*?\})" \
	  --glob '*.h' --glob '*.cpp' \
	  --glob '!*.gen.h' --glob '!test*.h' \
	  --glob '!thirdparty/**' \
	  --replace '$2'
done

Thanks! 😄

Methodology

They were initially found with this script and output, and then manually refined and expanded. Please note that:

• the script has problems with duplicates (similarly named classes in different files), and can't distinguish them, due to not actually interpreting C++ source code.
• some classes were manually marked with SKIP in the output, since they were either a duplicate - of a similarly named class that does descend from Object - or a descendant of such a duplicate.