If you need any changes, feel free to ping me

I'm contacting the security team at Godot for another issue

I have sent a message to the security team, please check it out. It's critical according to Akikido, won't provide any details here.

@AThousandShips

Please check out the mail I've sent, I don't know the security team

I'm not on any such team, please join the contributor chat instead and ask there

Also please edit previous comments instead of making several comments in a row, it creates a lot of unnecessary pings

I seem to have missed these projects in #92131. Good catch.

Will this be merged soon then?

@paulloz When can these changes be merged then? Also, what do you think of the message I sent regarding OS.cs?

Before anything can be merged you need to squash your commits into one, see the interactive rebase for details, if this is time critical that would be good to do now

Okay! Thanks for the tip

Hey! I wanted to say that I ACCIDENTLY did these changes via the web editor. Do I need to do it now or should I just redo the process locally?

Rebased it @AThousandShips

You need to squash the commits still, there should be exactly one

Now I hope it's good

This is probably fine to merge, and cherry-pick to 4.5 (and 4.4?), but I currently don't have a VS install on hand to test it.

I tested it locally & seemed to work. Still, we need the user's opinion. If it'll work, they might not create an issue. If it won't, they'll make an issue. If you already added 8.0 in some parts of the mono backend, doesn't this mean that this shouldn't create any issues? Also, I think you should cherry-pick to both 4.5 & 4.4

@paulloz Requesting your review

Can I get any info to when this'll be merged? I also want to try & tackle something else

@paulloz Please tell me when this'll be merged, my branch is becoming outdated

Can I get a review on this? My branch is becoming outdated & the .NET team maintainers aren't responding. My main worry is that my branch may have conflicts with the main branch & git is a confusing thing.

@AR-DEV-1 Please stop spamming contributors, this is not acceptable behavior.

PRs are merged once approved by maintainers and handled by the production team. This can take a while.

You don't need this PR merged to start new work, you can make a new branch on your fork. In the future, please avoid making PRs from your fork's master branch.

I'm sorry, shouldn't have done that.

?

PRs are merged once approved by maintainers and handled by the production team. This can take a while.

Please be patient.

Any updates?

Thanks! Congratulations on your first merged contribution! 🎉

This is probably fine to merge, and cherry-pick to 4.5 (and 4.4?), but I currently don't have a VS install on hand to test it.

Since I don't see the cherry-pick labels, just wanted to check: will this fix be cherry-picked to a future 4.5 patch release?

Cherry-picked for 4.5.2.

Cherry-picked for 4.4.2.