Use an array instead of TightLocalVector in RasterizerSceneGLES3::_render_uv2, to avoid allocation.#110781
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 22, 2025
Conversation
…_render_uv2`, to avoid allocation.
Ivorforce
force-pushed
the
rasterizer-render-uv2-allocation
branch
from
b3fdd4d to
bc7c05b
Compare
clayjohn
approved these changes
Sep 22, 2025
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Luckily this code is never called at run time (its for an editor utility)! But it definitely should be fixed so others don't copy this pattern.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just something small I randomly came across.
Due to misuse of
TightLocalVector, this actually avoids 4 allocations.