Allow trailing comma in preload#110775
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 1, 2025
Merged
Conversation
Contributor
Author
|
Failed build doesn't seem to be related to the PR, I've seen the same error on master. |
Member
|
Can you check if |
Contributor
Author
|
@Calinou no, Both of these work: assert(false,)
assert(false, "error",) |
Calinou
approved these changes
Sep 24, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
extends Node2D
var test = preload("res://node_2d.gd",)
func _ready():
print(test)
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110773
I wanted to add a test, but I don't know how to test
preload, it complains that the file I am trying to load doesn't exist (which makes sense, to be fair)