Fix AnimationPlayer to use StringName instead of String in the exposed API.#110767
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 7, 2025
Merged
Conversation
aaronfranke
reviewed
Sep 22, 2025
Ryan-000
force-pushed
the
Fix-AnimationPlayer-to-use-StringName
branch
from
4fe1041 to
71e1e08
Compare
Member
|
According to the godot-cpp check the apis are breaking backwards compatibility and failing github actions. |
Member
|
Yes, the compatibility breakage should be handled appropriately. See Handling Compatibility Breakages |
TokageItLab
approved these changes
Oct 4, 2025
Member
TokageItLab
left a comment
TokageItLab
left a comment
There was a problem hiding this comment.
I think the change itself is acceptable, but it need to add a compatibility file as mentioned above.
Ryan-000
force-pushed
the
Fix-AnimationPlayer-to-use-StringName
branch
2 times, most recently
from
e1ae9ca to
f9f6a11
Compare
Ryan-000
force-pushed
the
Fix-AnimationPlayer-to-use-StringName
branch
2 times, most recently
from
ae2dc7e to
64de3e6
Compare
Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Ryan-000
force-pushed
the
Fix-AnimationPlayer-to-use-StringName
branch
from
463c1e5 to
35999a1
Compare
github-project-automation
bot
moved this from Ready for review
to Done
in Animation Team Issue Triage
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the performance penalty of having to convert to and from
String↔StringNamein the exposedAnimationPlayerapi.