Fix drag and drop @export variable assignment when script has errors#110761
Fix drag and drop @export variable assignment when script has errors#110761Repiteo merged 1 commit intogodotengine:masterfrom
@export variable assignment when script has errors#110761Conversation
09c0864 to
78bf6aa
Compare
78bf6aa to
9b359fc
Compare
9b359fc to
18abe89
Compare
|
Tested a bit more, seems to work well. Should be merged into 4.6 since it fixes a bug for a feature that was just merged. #106341 |
18abe89 to
2270586
Compare
2270586 to
3978feb
Compare
|
just rebased, will work on this soon |
|
I have managed to fix the initial "bug" with saving the class name of the variable in the While this does work, like you said it seems to be a separate problem. If you also change the type of the There is an issue and PR about it: #104323, #104338 Anyways, updated to fix the original bug that this exposes with the name collision. Changing the type while the name collision error is happening does work correctly so I think it's fine. Don't like how it adds yet another for loop where if its a giant class it will run through a lot of properties, but I don't see a work around. It does only run once when the script doesn't have errors anymore though, so I think its fine. |
3978feb to
9dba414
Compare
9dba414 to
0dfa815
Compare
@export variable assignment when script has errors
|
Thanks! |
Closes #110735
Might be a bit slow with a combination of long file system paths(string comparision), lots of errors and adding a lot of export variables at once, but that's a very extreme case. Although if anyone has an idea on how to do this better in terms of time complexity, feel free to suggest changes. But overall should work fine.