X Tutup
Skip to content

Add GDSOFTCLASS to six inheritors of Object#110752

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
wheatear-dev:expand-110693
Sep 22, 2025
Merged

Add GDSOFTCLASS to six inheritors of Object#110752
Repiteo merged 1 commit intogodotengine:masterfrom
wheatear-dev:expand-110693

Conversation

@wheatear-dev
Copy link
Contributor

Further to bug report #110693, specifically a discussion with @Ivorforce in this comment, 6 classes were identified that inherit directly from Object, but that do not define GDCLASS or GDSOFTCLASS, and hence may fail static type checks as in this comment in my unit testing PR #102064.

This PR adds GDSOFTCLASS to each.

They were found using the following ripgrep command:

rg --pcre2 -n -H -o --multiline --multiline-dotall \
  '^(class\s+(\w+)\s*:\s*public\s+Object\s*\{(?:(?!GDCLASS|GDSOFTCLASS).)*?\})' \
  --glob '*.h' --glob '*.cpp' \
  --glob '!*.gen.h' --glob '!test*.h' \
  --glob '!thirdparty/**' --glob '!drivers/**' --glob '!modules/**' \
  --replace '$2'

@wheatear-dev wheatear-dev requested review from a team as code owners September 21, 2025 15:31
@wheatear-dev wheatear-dev requested review from a team September 21, 2025 15:31
@wheatear-dev wheatear-dev changed the title Add GDSOFTCLASS to six inheritors of Object Add GDSOFTCLASS to six inheritors of Object Sep 21, 2025
@Ivorforce Ivorforce added this to the 4.6 milestone Sep 21, 2025
@Repiteo Repiteo merged commit d069699 into godotengine:master Sep 22, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 22, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup