Fix XR tracker name changing at runtime#110703
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 23, 2025
Merged
Conversation
m4gr3d
approved these changes
Sep 19, 2025
BastiaanOlij
approved these changes
Sep 22, 2025
Contributor
|
I think this is something we have in a number of places. I use the |
BastiaanOlij
added
the
cherrypick:4.5
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this issue with
XRHandModifier3Dwhen working on my recent jam game.XRHandModifier3Dwill work great if you set thehand_trackerto the tracker name before it's added to the scene tree, but if you change it later, it will have no effect - it'll just keep using the old tracker.Looking at
XRBodyModifier3DandXRFaceModifier3D, they appear to have the same problem as well.