SCons: Fix Windows silence_msvc logfile encoding#110691
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 30, 2025
Merged
SCons: Fix Windows silence_msvc logfile encoding#110691Repiteo merged 1 commit intogodotengine:masterfrom
silence_msvc logfile encoding#110691Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Fix UnicodeEncodeError on cp932 environments by adding errors="replace" to log file open
Contributor
|
Could you squash your commits? See our pull request guidelines for more information |
Ruw-Van
force-pushed
the
fix-windows-logfile-encoding
branch
from
85388e0 to
b23b0dd
Compare
Contributor
Author
Thank you for pointing that out. Please do so. |
Calinou
added
platform:windows
cherrypick:4.4
Repiteo
approved these changes
Sep 27, 2025
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
akien-mga
changed the title
silence_msvc logfile encoding
Member
|
Cherry-picked for 4.5.1. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building Godot's source code in a Japanese-language Visual Studio 2022 environment, the build failed due to differences in character encoding between CP932 and Unicode.
This commit resolves the issue, allowing the build to complete successfully.