X Tutup
Skip to content

Editor: Generate translation data in separate cpp files#110618

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:editor-translations-h-cpp-split
Sep 17, 2025
Merged

Editor: Generate translation data in separate cpp files#110618
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:editor-translations-h-cpp-split

Conversation

@timothyqiu
Copy link
Member

Alternate of #110597

The big chunk of data is stored in a separate *_translations.gen.cpp beside the *_translations.gen.h file.

Regular source files don't need to be changed.

@timothyqiu timothyqiu requested a review from a team as a code owner September 17, 2025 15:18
@timothyqiu timothyqiu added bug topic:buildsystem cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 17, 2025
@AThousandShips AThousandShips added this to the 4.6 milestone Sep 17, 2025
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic idea! There's probably a lot of binary size to be saved from splitting other generated scripts into header/source pairs, but this is a great start

@Repiteo Repiteo merged commit e5f9f4d into godotengine:master Sep 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 17, 2025

Thanks!

@timothyqiu timothyqiu deleted the editor-translations-h-cpp-split branch September 17, 2025 23:52
ProfessorOctopus pushed a commit to ProfessorOctopus/godot that referenced this pull request Oct 5, 2025
…ions-h-cpp-split

Editor: Generate translation data in separate cpp files
@akien-mga
Copy link
Member

Cherry-picked for 4.5.1.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup