X Tutup
Skip to content

Fix the bug causing java.lang.StringIndexOutOfBoundsException crashes when showing the virtual keyboard#110611

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
m4gr3d:fix_show_keyboard_crash
Sep 19, 2025
Merged

Fix the bug causing java.lang.StringIndexOutOfBoundsException crashes when showing the virtual keyboard#110611
Repiteo merged 1 commit intogodotengine:masterfrom
m4gr3d:fix_show_keyboard_crash

Conversation

@m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Sep 17, 2025

Fixes #110610

@m4gr3d m4gr3d added this to the 4.6 milestone Sep 17, 2025
@m4gr3d m4gr3d requested a review from a team as a code owner September 17, 2025 06:14
@m4gr3d m4gr3d added bug platform:android topic:input cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 17, 2025
Copy link
Member

@Alex2782 Alex2782 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I first tried reproducing this exception on my Samsung tablet, not reproducible.

This crash occurs very often on the following devices:

System-on-a-Chip:

  • Mediatek
  • Spreadtrum

@Repiteo Repiteo merged commit f84123d into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks!

@m4gr3d m4gr3d deleted the fix_show_keyboard_crash branch September 19, 2025 02:41
@grusad
Copy link

grusad commented Sep 23, 2025

#110802 Report the same thing. Is this fix going into 4.5.1? Is there a workaround fix for this? We need to get a fix for this quite asap. Nobody can chat in our game atm.

@grusad
Copy link

grusad commented Sep 23, 2025

I can reproduce the bug. It happends when you double tap the input field when its empty on 4.5 atm

@syntaxerror247
Copy link
Member

syntaxerror247 commented Sep 23, 2025

#110802 Report the same thing. Is this fix going into 4.5.1? Is there a workaround fix for this? We need to get a fix for this quite asap. Nobody can chat in our game atm.

Yes. This fix would be backported to 4.5

@akien-mga
Copy link
Member

Cherry-picked for 4.5.1.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android editor][Play store crash] Crash occurs occasionally when the virtual keyboard is shown

6 participants

X Tutup