X Tutup
Skip to content

Fix color picker shape minimum size#110581

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:round_like_earth
Oct 28, 2025
Merged

Fix color picker shape minimum size#110581
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:round_like_earth

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 16, 2025

Fixes #110325

@KoBeWi KoBeWi added this to the 4.6 milestone Sep 16, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner September 16, 2025 15:44
@BrotherShort
Copy link
Contributor

Why is margin_bottom 8?
After you change, the circle control will be perfectly circular. But value_slider's height is still 8 more than circle.
So I want to know why should margin_bottom keep 8?
New layer:
image

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 17, 2025

Without the margin, the shape position is asymmetrical vertically:
image
Although it seems to happen only in the editor theme. Default theme has opposite issue...

EDIT:
Nevermind, it's just the panel has a huge margin. That's a separate issue I think.

EDIT2:
I removed the MarginContainers completely.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes non-round shape, and spacing between wheel and side/bottom sliders looks better.

Before After
Image Image

@Repiteo Repiteo merged commit d8558da into godotengine:master Oct 28, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 28, 2025

Thanks!

@KoBeWi KoBeWi deleted the round_like_earth branch October 28, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ColorPicker Wheel / Circle are not perfectly circular

4 participants

X Tutup