Fix --dump-extension-api-with-docs indentation#110557
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 16, 2025
Merged
Fix --dump-extension-api-with-docs indentation#110557Repiteo merged 1 commit intogodotengine:masterfrom
--dump-extension-api-with-docs indentation#110557Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
changed the title
AThousandShips
changed the title
--dump-extension-api-with-docs indentation
AThousandShips
added
bug
topic:gdextension
regression
cherrypick:4.5
Member
|
Please update your commit message to describe what the fix does, and we try to avoid linking issues in the commit as it creates a lot of noise in the issue whenever the commit is updated |
xml codeblock indentation was changed from spaces to tabs but the tabs were being replaced with empty strings when exported with --dump-extension-api-with-docs, this is small change so that tab characters are no longer replaced.
Splizard
force-pushed
the
fix-dump-extension-api-with-docs-indentation
branch
from
68a9257 to
e913155
Compare
dsnopek
approved these changes
Sep 16, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks!
I haven't tested, but the code changes look good to me. This matches this line in editor_help.cpp:
https://github.com/godotengine/godot/blob/master/editor/doc/editor_help.cpp#L2489
It was updated in #89819 with the switch from spaces to tabs, but the code in extension_api_dump.cpp wasn't updated to match
Calinou
approved these changes
Sep 16, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected.
Previously, extension_api.json had no instances of \t\t (two consecutive tabs or more), but now it does.
Contributor
|
Thanks! |
ProfessorOctopus
pushed a commit
to ProfessorOctopus/godot
that referenced
this pull request
Sep 17, 2025
…n-api-with-docs-indentation Fix `--dump-extension-api-with-docs` indentation
Contributor
|
Cherry-picked to 4.5 |
Repiteo
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xml codeblock indentation was changed from spaces to tabs but the tabs were being replaced with empty strings when exported with --dump-extension-api-with-docs, this is small change so that tab characters are no longer replaced.