X Tutup
Skip to content

GDExtension: Update warning about gdextension_special_compat_hashes.cpp to prevent confusion#110537

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
dsnopek:gdextension-do-not-update-gdextension-special-compat-hashes
Sep 17, 2025
Merged

GDExtension: Update warning about gdextension_special_compat_hashes.cpp to prevent confusion#110537
Repiteo merged 1 commit intogodotengine:masterfrom
dsnopek:gdextension-do-not-update-gdextension-special-compat-hashes

Conversation

@dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Sep 15, 2025

If there's an invalid hash in the list of hashes in gdextension_special_compat_hashes.cpp, it'll print a warning like this:

 Compatibility hash 2865980031 for Performance::add_custom_monitor() mapped to non-existent hash 4099036814. Please update gdextension_special_compat_hashes.cpp.

Due to the poor wording on my part (I wrote that message!) this has led a few people to think they needed update gdextension_special_compat_hashes.cpp to account for their changes, rather than add a compatibility method (which is what they actually should do in 99.9% of cases).

This PR attempts to reword this message to eliminate the confusion.

@dsnopek dsnopek added this to the 4.x milestone Sep 15, 2025
@dsnopek dsnopek requested a review from a team as a code owner September 15, 2025 19:09
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 16, 2025
@Repiteo Repiteo merged commit f279257 into godotengine:master Sep 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 17, 2025

Thanks!

ProfessorOctopus pushed a commit to ProfessorOctopus/godot that referenced this pull request Sep 17, 2025
…-update-gdextension-special-compat-hashes

GDExtension: Update warning about `gdextension_special_compat_hashes.cpp` to prevent confusion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup