Add one padding frame to QOA buffer for short streams#110515
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 16, 2025
Merged
Add one padding frame to QOA buffer for short streams#110515Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
clayjohn
added
bug
topic:audio
regression
cherrypick:4.5
bruvzg
approved these changes
Sep 15, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
The issue happens if the WAV file has a baked loop end right at the end of stream
If this is the reason for extra data, fix should be fine. But might be worth adding boundary check to the place it was crashing just in case.
AThousandShips
approved these changes
Sep 15, 2025
Calinou
approved these changes
Sep 15, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected.
Contributor
|
Thanks! |
Contributor
|
Cherry-picked to 4.5 |
Repiteo
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110482.
The issue happens if the WAV file has a baked loop end right at the end of stream, and only if compress mode is set to
FORMAT_QOA.I have applied @bruvzg's solution. The padding frame should never be reached unless it's that specific case. Didn't notice any audible pops after this.