[macOS] Use productCategory instead of vendorName for joypad name in SDL#110500
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 4, 2025
Merged
[macOS] Use productCategory instead of vendorName for joypad name in SDL#110500Repiteo merged 1 commit intogodotengine:masterfrom
productCategory instead of vendorName for joypad name in SDL#110500Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
sorascode
changed the title
Contributor
|
Hm, interesting, should we also propose this change to upstream SDL? |
Contributor
Author
I think that would be a good idea too yea |
Contributor
Author
|
This has been merged into SDL itself so this pr simply updates SDL now :) |
Contributor
Author
|
Is there any info on when this would be merged? |
akien-mga
force-pushed
the
fix-macos-joy-name
branch
from
e4cdfb6 to
92172ca
Compare
Member
|
I rebased the PR to adjust how the thirdparty modification is done to follow our guidelines. Should be good to go now if it was accepted upstream (I see it was merged in the dev branch so it will be available when we upgrade to 3.4.x). |
akien-mga
changed the title
productCategory instead of vendorName for joypad name in SDL
akien-mga
approved these changes
Nov 4, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the apple sdl driver to use
productCategoryfor the controller name instead ofvendorNamewhen available. This was already updated before the switch to sdl was made so this PR merely pulls those changes into our sdl implementation.Please see #104894 for more details.