X Tutup
Skip to content

[macOS] Remove old embedded window joystick init code.#110491

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:emb_j_init_msg
Sep 23, 2025
Merged

[macOS] Remove old embedded window joystick init code.#110491
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:emb_j_init_msg

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 13, 2025

See #110490

@bruvzg bruvzg added this to the 4.6 milestone Sep 13, 2025
@bruvzg bruvzg requested a review from a team as a code owner September 13, 2025 14:58
@bruvzg bruvzg added bug platform:macos topic:input cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 13, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on the joypads demo, this fixes the warning that was being printed. However, controller support still doesn't work on macOS 26 (wired DualSense) if game window embedding is enabled.

@Repiteo Repiteo merged commit 0ef1c07 into godotengine:master Sep 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 23, 2025

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.5.1.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup