X Tutup
Skip to content

Fix documentation for embed_subwindows project setting #110448

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
CookieBadger:embed-subwindows-doc
Sep 17, 2025
Merged

Fix documentation for embed_subwindows project setting #110448
Repiteo merged 1 commit intogodotengine:masterfrom
CookieBadger:embed-subwindows-doc

Conversation

@CookieBadger
Copy link
Contributor

I might be mistaken, but from what I understand embed_subwindows is equivalent to single_window_mode, not inverted.

@CookieBadger CookieBadger requested a review from a team as a code owner September 12, 2025 08:27
@CookieBadger CookieBadger changed the title Fixup documentation for embed/subwindows Fixup documentation for embed subwindows Sep 12, 2025
@AThousandShips AThousandShips changed the title Fixup documentation for embed subwindows Fix documentation for embed subwindows Sep 12, 2025
@AThousandShips AThousandShips changed the title Fix documentation for embed subwindows Fix documentation for embed_subwindows project setting Sep 12, 2025
@AThousandShips AThousandShips added bug documentation cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 12, 2025
@AThousandShips AThousandShips added this to the 4.6 milestone Sep 12, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I originally wrote this line, not sure why I thought it was inverted.

@Repiteo Repiteo merged commit 31f0eda into godotengine:master Sep 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 17, 2025

Thanks!

ProfessorOctopus pushed a commit to ProfessorOctopus/godot that referenced this pull request Sep 17, 2025
…ows-doc

Fix documentation for `embed_subwindows` project setting
@akien-mga akien-mga removed cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup