X Tutup
Skip to content

Improve look of some buttons inside the inspector#110434

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:inspector_button_tidyup
Sep 17, 2025
Merged

Improve look of some buttons inside the inspector#110434
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:inspector_button_tidyup

Conversation

@YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Sep 11, 2025

  • Slight increase the horizontal padding.
  • Switch the hover effect from "Button" to "FlatButton" style (not noticeable now, but will be in someone's theme. 🙂).
  • Fix some properties overlapping the animation key button when the inspector width is very small. [1]
  • Fix hovering effect staying when the mouse leaves the button vertically in properties that unfold.
Before After
Screenshot_20250911_181146 Screenshot_20250911_180911

[1] Caused a regression, fixed by #110827. If this is cherry-picked, that PR needs to be as well.

@YeldhamDev YeldhamDev added this to the 4.6 milestone Sep 11, 2025
@YeldhamDev YeldhamDev requested a review from a team September 11, 2025 21:37
@YeldhamDev YeldhamDev added bug enhancement topic:editor cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 11, 2025
@YeldhamDev YeldhamDev force-pushed the inspector_button_tidyup branch from 1876e52 to e0c0d0d Compare September 12, 2025 13:59
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much difference tbh, aside from the key button going out of bounds:

Image

Can't reproduce the hover bug either.

The changes seem fine though.

@YeldhamDev
Copy link
Member Author

@KoBeWi

I don't see much difference tbh

I had to keep the difference small, otherwise the extra space looks odd since they are flat.

aside from the key button going out of bounds

Can you tell in which property this happens?

Can't reproduce the hover bug either.

Try it with WorldEnvironment:

Screencast_20250912_133425.webm

@KoBeWi
Copy link
Member

KoBeWi commented Sep 12, 2025

Can you tell in which property this happens?

Sprite2D's region_enabled.

@YeldhamDev YeldhamDev force-pushed the inspector_button_tidyup branch from e0c0d0d to 556130e Compare September 12, 2025 23:51
@YeldhamDev
Copy link
Member Author

Fixed the out-of-bounds issue.

@YeldhamDev YeldhamDev force-pushed the inspector_button_tidyup branch from 556130e to 06b155a Compare September 14, 2025 15:30
@Repiteo Repiteo merged commit 4eaa0ef into godotengine:master Sep 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 17, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the inspector_button_tidyup branch September 17, 2025 17:09
ProfessorOctopus pushed a commit to ProfessorOctopus/godot that referenced this pull request Oct 5, 2025
…n_tidyup

Improve look of some buttons inside the inspector
@Repiteo Repiteo removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup