Fix numpad emulation in 3d navigation shortcuts#110428
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Nov 1, 2025
Merged
Fix numpad emulation in 3d navigation shortcuts#110428akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
CookieBadger
force-pushed
the
fix-viewport-numpad-emulation
branch
from
fe59c42 to
099c740
Compare
AThousandShips
added
bug
topic:editor
topic:3d
cherrypick:4.4
Contributor
Author
|
just noting, since it's marked for cherry pick: the issue probably also exists in versions prior to 4.4, but you have to first toggle |
Calinou
reviewed
Sep 15, 2025
Member
There was a problem hiding this comment.
Tested locally (Linux/X11, fr-oss keyboard layout), it mostly works as expected.
Ctrl + 2 and Ctrl + Alt + 2 work, but not any of the other viewport split shortcuts like Ctrl + 1. They work after switching to QWERTY, so it's probably due to the original bindings.
To fix this, lines 9546-9551 of node_3d_editor_plugin.cpp should be changed to:
p->add_radio_check_shortcut(ED_SHORTCUT("spatial_editor/1_viewport", TTRC("1 Viewport"), KeyModifierMask::CMD_OR_CTRL + Key::KEY_1, true), MENU_VIEW_USE_1_VIEWPORT);
p->add_radio_check_shortcut(ED_SHORTCUT("spatial_editor/2_viewports", TTRC("2 Viewports"), KeyModifierMask::CMD_OR_CTRL + Key::KEY_2, true), MENU_VIEW_USE_2_VIEWPORTS);
p->add_radio_check_shortcut(ED_SHORTCUT("spatial_editor/2_viewports_alt", TTRC("2 Viewports (Alt)"), KeyModifierMask::ALT + KeyModifierMask::CMD_OR_CTRL + Key::KEY_2, true), MENU_VIEW_USE_2_VIEWPORTS_ALT);
p->add_radio_check_shortcut(ED_SHORTCUT("spatial_editor/3_viewports", TTRC("3 Viewports"), KeyModifierMask::CMD_OR_CTRL + Key::KEY_3, true), MENU_VIEW_USE_3_VIEWPORTS);
p->add_radio_check_shortcut(ED_SHORTCUT("spatial_editor/3_viewports_alt", TTRC("3 Viewports (Alt)"), KeyModifierMask::ALT + KeyModifierMask::CMD_OR_CTRL + Key::KEY_3, true), MENU_VIEW_USE_3_VIEWPORTS_ALT);
p->add_radio_check_shortcut(ED_SHORTCUT("spatial_editor/4_viewports", TTRC("4 Viewports"), KeyModifierMask::CMD_OR_CTRL + Key::KEY_4, true), MENU_VIEW_USE_4_VIEWPORTS);This will make the bindings physical, so they work on any keyboard layout.
CookieBadger
force-pushed
the
fix-viewport-numpad-emulation
branch
from
099c740 to
9ec9d9a
Compare
Contributor
Author
|
@Calinou updated. |
CookieBadger
force-pushed
the
fix-viewport-numpad-emulation
branch
from
9ec9d9a to
e3eef8c
Compare
Contributor
Author
|
rebased. |
Calinou
approved these changes
Oct 30, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally on Windows (AZERTY keyboard layout), it works as expected. Code looks good to me.
Member
|
Thanks! |
akien-mga
removed
cherrypick:4.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110427.
I was noticing this issue a while, and I saw it wasn't yet fixed for 4.5, so I tried a quick fix, but not sure if this
duplicateworkaround is how you would do it.