X Tutup
Skip to content

Fix AudioBus editor not updating layout path#110422

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
KoBeWi:audio_bus_factor
Dec 21, 2025
Merged

Fix AudioBus editor not updating layout path#110422
akien-mga merged 1 commit intogodotengine:masterfrom
KoBeWi:audio_bus_factor

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 11, 2025

Fixes #47911

@KoBeWi KoBeWi added this to the 4.6 milestone Sep 11, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner September 11, 2025 14:10
@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 11, 2025

I pushed a better fix that makes use of UID.
This editor is a bit special, because the Resource is generated on save, not actually being edited.

The saving should now work properly for any BusLayout, but the path label is not updating when the file is renamed. It can be fixed separately, as not sure how to do it properly.

@YeldhamDev
Copy link
Member

The PR fixes the issue when the file is moved inside the editor. If moved from outside it still happens, but I assume that can't be avoided.

but the path label is not updating when the file is renamed. It can be fixed separately, as not sure how to do it properly.

FileSystemDock has the files_moved signal, couldn't that be used?

@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 18, 2025

FileSystemDock has the files_moved signal, couldn't that be used?

Yeah, that worked.

The PR fixes the issue when the file is moved inside the editor. If moved from outside it still happens, but I assume that can't be avoided.

That's a separate bug. Moving a file externally does not update the UID's path immediately.

@YeldhamDev
Copy link
Member

That fixed the renaming, but now the original bug is back.

@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 19, 2025

I did quite a bit more changes and it should be working now. Also fixed a couple additional problems with UIDs and path label.

That fixed the renaming, but now the original bug is back.

It wasn't back, there was a case I missed.

Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine now.

@akien-mga akien-mga merged commit d61c12f into godotengine:master Dec 21, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default_bus_layout.tres is generated at old location after moved

3 participants

X Tutup