X Tutup
Skip to content

Fix favorite folders that are outside of the project being displayed in FileSystemDock's file list#110415

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
fstxz:fix_favorites
Sep 25, 2025
Merged

Fix favorite folders that are outside of the project being displayed in FileSystemDock's file list#110415
Repiteo merged 1 commit intogodotengine:masterfrom
fstxz:fix_favorites

Conversation

@fstxz
Copy link
Contributor

@fstxz fstxz commented Sep 11, 2025

Fixes #110406

The same way _update_tree does it:

for (int i = 0; i < favorite_paths.size(); i++) {
const String &favorite = favorite_paths[i];
if (!favorite.begins_with("res://")) {
continue;
}

@fstxz fstxz requested a review from a team September 11, 2025 12:49
@AThousandShips AThousandShips added bug topic:editor usability cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 11, 2025
@AThousandShips AThousandShips added this to the 4.6 milestone Sep 11, 2025
@Repiteo Repiteo merged commit 5088a93 into godotengine:master Sep 25, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 25, 2025

Thanks!

@fstxz fstxz deleted the fix_favorites branch October 1, 2025 13:16
@akien-mga
Copy link
Member

Cherry-picked for 4.5.1.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:editor usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Favorite folders that are outside of the project are shown in FileSystem dock when it's in split mode

5 participants

X Tutup