X Tutup
Skip to content

Expand completion confirmation to handle completion in Shift selection mode#110411

Open
Mostafa808 wants to merge 1 commit intogodotengine:masterfrom
Mostafa808:editor-selection-completion
Open

Expand completion confirmation to handle completion in Shift selection mode#110411
Mostafa808 wants to merge 1 commit intogodotengine:masterfrom
Mostafa808:editor-selection-completion

Conversation

@Mostafa808
Copy link

@Mostafa808 Mostafa808 commented Sep 11, 2025

It is related to this issue: #110393
I am not sure what are all the use cases of this completion function, so I think it requires some testing.
I tested it with additional () and ( while applying completion and it seems to be working fine.

@Mostafa808 Mostafa808 requested a review from a team as a code owner September 11, 2025 11:16
@AThousandShips AThousandShips changed the title Expanding completion confirmation to handle completion in Shift selection mode Expand completion confirmation to handle completion in Shift selection mode Sep 11, 2025
@AThousandShips AThousandShips added enhancement topic:gui bug crash cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release and removed enhancement labels Sep 11, 2025
@AThousandShips AThousandShips added this to the 4.6 milestone Sep 11, 2025
@kitbdev
Copy link
Contributor

kitbdev commented Sep 11, 2025

@Mostafa808 Mostafa808 force-pushed the editor-selection-completion branch from 00322aa to 3357e65 Compare October 7, 2025 17:58
@KoBeWi
Copy link
Member

KoBeWi commented Oct 7, 2025

The issue was fixed, is this still needed?

@Mostafa808
Copy link
Author

Mostafa808 commented Oct 7, 2025 •
edited
Loading

The crash issue was fixed, I just updated this PR to be a possible solution to the behavior in this comment
Other alternative might be disabling the completion on detecting selection mode through editor
Should we need to close this PR and open new ones instead?

@KoBeWi
Copy link
Member

KoBeWi commented Oct 7, 2025

Should we need to close this PR and open new ones instead?

No, it's fine.

@kitbdev kitbdev removed the crash label Oct 11, 2025
@kitbdev
Copy link
Contributor

kitbdev commented Oct 11, 2025

Do any IDEs support selecting while code completing? I'd rather cancel the code completion if a selection is made.

@Mostafa808
Copy link
Author

Mostafa808 commented Oct 11, 2025

Do any IDEs support selecting while code completing?

I do not know an editor with that behavior.
I also do not know one that applies code completion to multiple cursors although this behavior exists in Godot editor.
It is an alternative anyway, if applying code completion while in selection mode might introduce other issues, it should instead be disabled completely by detecting selection mode.

@Repiteo Repiteo modified the milestones: 4.6, 4.x Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release topic:gui

Projects

None yet

Milestone

4.x

Development

Successfully merging this pull request may close these issues.

5 participants

@Mostafa808 @kitbdev @KoBeWi @Repiteo @AThousandShips
X Tutup