X Tutup
Skip to content

[TextServer] Use a separate flag to disable min. string length for adding ellipsis.#110408

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:el_trim_w
Nov 21, 2025
Merged

[TextServer] Use a separate flag to disable min. string length for adding ellipsis.#110408
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:el_trim_w

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 11, 2025

Fixes #110389

@bruvzg bruvzg added this to the 4.6 milestone Sep 11, 2025
@bruvzg bruvzg requested review from a team as code owners September 11, 2025 10:06
@arkology
Copy link
Contributor

Btw should ellipsis be taken into account for minimum size?

@bruvzg
Copy link
Member Author

bruvzg commented Sep 11, 2025

Btw should ellipsis be taken into account for minimum size?

When trimming is enabled, there's no minimum size (width) at all.

@Calinou Calinou added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 11, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Sep 23, 2025

Not completely related, but there is some inconsistency in naming. The documentation calls the option Ellipsis Force
image
While it appears as Always in the inspector
image

@Repiteo
Copy link
Contributor

Repiteo commented Sep 23, 2025

Needs rebase after #110819

@Repiteo
Copy link
Contributor

Repiteo commented Nov 20, 2025

Needs another rebase, sorry

@Repiteo Repiteo merged commit 47d6ce2 into godotengine:master Nov 21, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 21, 2025

Thanks!

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New OVERRUN_TRIM_ELLIPSIS_FORCE and OVERRUN_TRIM_WORD_ELLIPSIS_FORCE options force an ellipsis too much

6 participants

X Tutup