Set language encoding flag when using Pack Project as ZIP#110387
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 22, 2025
Merged
Set language encoding flag when using Pack Project as ZIP#110387Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
timothyqiu
added
bug
topic:editor
cherrypick:4.5
Calinou
approved these changes
Sep 10, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Code looks good to me.
PS: I'm curious as to why this code doesn't use ZIPPacker instead. In the long run, it would make sense to avoid low-level minizip usage unless absolutely necessary.
bruvzg
approved these changes
Sep 11, 2025
timothyqiu
force-pushed
the
project-zip-utf8
branch
from
1343d04 to
cadd08d
Compare
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #78732
Currently, the zip archive produced by the "Pack Project as ZIP" command does not have its language encoding flag set. Therefore, the filenames inside might not be recognized as UTF-8 on Windows, causing garbled filenames in extracted files.