Make text-related nodes translation domain aware#110378
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 16, 2025
Merged
Make text-related nodes translation domain aware#110378Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
bruvzg
approved these changes
Sep 11, 2025
timothyqiu
force-pushed
the
rtl-preview
branch
from
7534ec3 to
11f35a4
Compare
KoBeWi
reviewed
Sep 21, 2025
KoBeWi
reviewed
Sep 21, 2025
- Makes `is_layout_rtl()` translation domain aware - Makes various text-drawing controls translation domain aware - Makes translation preview use the project's fallback locale when disabled
timothyqiu
force-pushed
the
rtl-preview
branch
from
11f35a4 to
172c80d
Compare
Member
Author
|
Instead of adding |
KoBeWi
approved these changes
Oct 15, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #96921
Closes #97893
Supersedes #97918
In this PR:
is_layout_rtl()translation domain aware.TranslationServer.get_tool_locale().An internal
Object::_get_locale()helper method is added to simplify getting the actual locale / language to use.Peek.2025-09-10.17-36.mp4
Test project used in the video (font not included): rtl-preview.zip
There're lots of controls containing the word "Diameter" in the test project. They are to show how the language affects glyph rendering. Both Chinese and Japanese uses the word 直径 for diameter, but the two characters should be rendered differently: 直径 vs 直径.