Add check is_inside_tree() to SkeletonModifier3D as base class#110371
Closed
TokageItLab wants to merge 1 commit intogodotengine:masterfrom
Closed
Add check is_inside_tree() to SkeletonModifier3D as base class#110371TokageItLab wants to merge 1 commit intogodotengine:masterfrom
is_inside_tree() to SkeletonModifier3D as base class#110371TokageItLab wants to merge 1 commit intogodotengine:masterfrom
Conversation
TokageItLab
force-pushed
the
inside-check-mod
branch
from
f8cf706 to
8634d39
Compare
Closed
TokageItLab
force-pushed
the
inside-check-mod
branch
from
8634d39 to
704baa0
Compare
TokageItLab
force-pushed
the
inside-check-mod
branch
from
704baa0 to
705e17e
Compare
Member
Author
|
Contained by #110120 |
github-project-automation
bot
moved this from Ready for review
to Done
in Animation Team Issue Triage
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_inside_tree()check to SpringBoneSimulator3D #104167Since these checks are also required in the implementation of #110120 and #110336, I considered it appropriate to implement them in the base class. Also I believe this has now been made safer through the fix in #110145.