Add option to BoneConstraint3D to make reference target allow to set Node3D#110336
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 14, 2025
Merged
Add option to BoneConstraint3D to make reference target allow to set Node3D#110336Repiteo merged 1 commit intogodotengine:masterfrom
BoneConstraint3D to make reference target allow to set Node3D#110336Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
TokageItLab
force-pushed
the
constraint-mod-node
branch
from
7831b6d to
b5868b4
Compare
TokageItLab
force-pushed
the
constraint-mod-node
branch
from
b5868b4 to
4e2a6d3
Compare
TokageItLab
changed the title
BoneConstraint3D to make reference target allow nodeBoneConstraint3D to make reference target allow to set Node3D
TokageItLab
force-pushed
the
constraint-mod-node
branch
3 times, most recently
from
808ad2c to
9e9ab03
Compare
Closed
TokageItLab
force-pushed
the
constraint-mod-node
branch
2 times, most recently
from
261bc51 to
98709ef
Compare
TokageItLab
force-pushed
the
constraint-mod-node
branch
from
98709ef to
7d98cca
Compare
TokageItLab
force-pushed
the
constraint-mod-node
branch
2 times, most recently
from
5fa5d96 to
c680327
Compare
TokageItLab
force-pushed
the
constraint-mod-node
branch
4 times, most recently
from
eb919c8 to
a457efa
Compare
TokageItLab
force-pushed
the
constraint-mod-node
branch
from
a457efa to
a9a63d2
Compare
TokageItLab
force-pushed
the
constraint-mod-node
branch
3 times, most recently
from
64e9e54 to
6f335b2
Compare
15 tasks
TokageItLab
force-pushed
the
constraint-mod-node
branch
3 times, most recently
from
5c8a94a to
6afe51d
Compare
TokageItLab
force-pushed
the
constraint-mod-node
branch
from
6afe51d to
a57f961
Compare
lyuma
approved these changes
Nov 14, 2025
Contributor
lyuma
left a comment
lyuma
left a comment
There was a problem hiding this comment.
Discussed in meeting. Looks good
I think there is room to
Improve NodePath -> Node3D* cache in the future (maybe using ObjectID or Variant) but this optimization should be a separate PR after we finish IK
TokageItLab
moved this from Ready for review
to Approved, Waiting for Production
in Animation Team Issue Triage
github-project-automation
bot
moved this from Approved, Waiting for Production
to Done
in Animation Team Issue Triage
Contributor
|
Thanks! |
|
follow further discussion of godot demo on 3D IK here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting a Node3D as the reference target for BoneConstraint3Ds.
The video below is a demo combined with IK #110120
constraint_with_ik.mp4
Other minor changes:
Project file:
ik_test_match_target.zip
(require to merge both #110120 and this PR)