Fix reflection probes not recreating downsampled textures when mode changes.#110330
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 17, 2025
Merged
Conversation
clayjohn
approved these changes
Sep 8, 2025
Calinou
approved these changes
Sep 8, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me. (I've tested this with texture array reflections disabled as well, just in case.)
Testing project: test_reflection_probe_once_always.zip
I was able to reproduce the original issue on master.
Contributor
|
Thanks! |
ProfessorOctopus
pushed a commit
to ProfessorOctopus/godot
that referenced
this pull request
Oct 5, 2025
…-size-leak Fix reflection probes not recreating downsampled textures when mode changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the size of the downsampled radiance map was not updated properly for reflection probes when changing between scenes, leading to much lower quality visuals if the reflection probe it happens to reuse was created first with the real time mode instead. Viceversa, the real time probe would end up much higher quality than intended if an scene was opened with a probe that used the Update Once method instead.
Both screenshots here were taken with the same scene, the main difference being that a different scene was opened first that had a reflection probe configured in Update Once mode and the other scene was in Update Always mode.