Open translation CSV in the text editor instead of printing errors.#110323
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 28, 2025
Merged
Open translation CSV in the text editor instead of printing errors.#110323Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
KoBeWi
reviewed
Sep 8, 2025
|
|
||
| String import_reload_fn; | ||
|
|
||
| HashSet<String> force_textfile_extensions; |
Member
There was a problem hiding this comment.
Not sure if this kind of future-proofing is worth it now. It could be hard-coded to CSV, with a comment to add a HashSet if more extensions are needed.
Though either way is fine probably.
KoBeWi
approved these changes
Sep 8, 2025
Contributor
|
Thanks! |
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110311