X Tutup
Skip to content

Use language command line argument to override editor locale.#110318

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:ed_loc_cmd
Sep 19, 2025
Merged

Use language command line argument to override editor locale.#110318
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:ed_loc_cmd

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 8, 2025

language argument was used for running projects, but was completely ignored by editor/pm. Argument is only applied during initial load and is not used when changing locale from the editor settings.

Fixes #110273

@bruvzg bruvzg added this to the 4.6 milestone Sep 8, 2025
@bruvzg bruvzg requested a review from a team as a code owner September 8, 2025 07:30
@bruvzg bruvzg added the bug label Sep 8, 2025
@bruvzg bruvzg requested a review from a team September 8, 2025 07:30
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

However, the CLI argument doesn't carry over from the project manager to the editor, while I would expect it to. (I don't expect it to carry over from the project manager to the running project when using Run though.)

@Calinou Calinou added topic:i18n cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 8, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Sep 8, 2025

This can be fixed with forwardable_cli_arguments.

@bruvzg
Copy link
Member Author

bruvzg commented Sep 8, 2025

However, the CLI argument doesn't carry over from the project manager to the editor

Will update it tomorrow. Done.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now 🙂

@Repiteo Repiteo merged commit 8900a5e into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks!

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup