Fix vertical alignment of Inspector category titles#110303
Fix vertical alignment of Inspector category titles#110303Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
Further investigation shows that this may be a platform specific issue. This doesn't seem to be a problem on other platforms, and while this PR fixes it on Windows, it causes a regression for other platforms. |
| float font_height = font->get_height(font_size); | ||
| float text_pos_y = get_size().height - (font_height / 2) + v_margin_offset; | ||
| Point2 text_pos = Point2(ofs, text_pos_y).round(); | ||
| draw_string(font, text_pos, label, HORIZONTAL_ALIGNMENT_LEFT, w, font_size, theme_cache.font_color); |
There was a problem hiding this comment.
Ref<TextLine> tl;
tl.instantiate();
tl->add_string(label, font, font_size);
tl->set_width(w);
tl->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_LEFT);
float text_pos_y = (get_size().height - tl->get_size().height) / 2 + v_margin_offset;
Point2 text_pos = Point2(ofs, text_pos_y).round();
tl->draw(get_canvas_item(), text_pos, theme_cache.font_color);Using real text metrics should always work, regardless of fonts and system font fallbacks in use.
There was a problem hiding this comment.
I can confirm this works, at least on my end. Will need someone else to validate. I have integrated this into the PR
# Conflicts: # editor/inspector/editor_inspector.cpp
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally on Linux, it works as expected.
Default settings at various editor scales
| 75% | 100% | 125% |
|---|---|---|
 |
 |
 |
| 150% | 175% | 200% |
|---|---|---|
 |
 |
 |
Custom settings
| Inter, no hinting | Adwaita Mono, full hinting | Comic Neue, no hinting, size 17 |
|---|---|---|
 |
 |
 |
|
Remember to squash commits into a single commit so this can be merged. |
Calinou
added
the
cherrypick:4.5
|
I tested this again, works as expected now. |
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Fix vertical alignment of Inspector category titles
akien-mga
removed
the
cherrypick:4.5
9 participants
Fixes #110302
Before:
After:
