X Tutup
Skip to content

Image: Optimize manual format conversion#110271

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
BlueCube3310:image-conv-opti-incompatible
Oct 22, 2025
Merged

Image: Optimize manual format conversion#110271
Repiteo merged 1 commit intogodotengine:masterfrom
BlueCube3310:image-conv-opti-incompatible

Conversation

@BlueCube3310
Copy link
Contributor

@BlueCube3310 BlueCube3310 commented Sep 5, 2025

Makes conversion faster for formats that have to fall back on get_/set_pixel (i.e. RGBA8 - RGBAH) by avoiding copying entire mipmaps. This makes conversion ~1.70x faster.

2048x2048, 11 mipmaps, RGB8 -> RGBH:
Before - 70 ms
After - 30 ms

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner September 5, 2025 08:53
@BlueCube3310 BlueCube3310 added this to the 4.x milestone Sep 5, 2025
@BlueCube3310 BlueCube3310 force-pushed the image-conv-opti-incompatible branch from 9e0643a to 8661b84 Compare September 5, 2025 09:36
@BlueCube3310 BlueCube3310 changed the title Image: Optimize format conversion Image: Optimize manual format conversion Sep 5, 2025
@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 10, 2025
@BlueCube3310 BlueCube3310 force-pushed the image-conv-opti-incompatible branch from 8661b84 to d653f64 Compare September 21, 2025 17:28
@BlueCube3310 BlueCube3310 force-pushed the image-conv-opti-incompatible branch from d653f64 to b63ec3d Compare October 22, 2025 12:58
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@Repiteo Repiteo merged commit 3776411 into godotengine:master Oct 22, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 22, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup