Image: Support generating mipmaps for all uncompressed formats#110257
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 1, 2025
Merged
Image: Support generating mipmaps for all uncompressed formats#110257Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
bruvzg
reviewed
Sep 4, 2025
BlueCube3310
force-pushed
the
mip-gen-all-formats
branch
2 times, most recently
from
7c840fd to
d0ae84d
Compare
Calinou
approved these changes
Sep 9, 2025
Member
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Testing project: test_image_mipmaps.zip
Note that on RGB565, mipmaps will sometimes bias towards green or purple for similar reasons as described in this video. There's not much we can do about it. In the this example, the pixels should average to a neutral gray but it looks a bit green instead:
The same texture in RGB8 for comparison:
BlueCube3310
force-pushed
the
mip-gen-all-formats
branch
from
d0ae84d to
127f12d
Compare
Contributor
|
Needs rebase |
BlueCube3310
force-pushed
the
mip-gen-all-formats
branch
from
127f12d to
f64ccad
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports generating mipmaps for RGB565 and RGBA4444.
TODO: