X Tutup
Skip to content

Properly inspect old remote selection#110251

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:semote_relect
Sep 24, 2025
Merged

Properly inspect old remote selection#110251
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:semote_relect

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 4, 2025

Fixes #33894

The bug basically boils down to remote tree preserving selection between sessions when node structure happens to match. It's sometimes useful, so I made it work properly instead of removing this behavior.

@KoBeWi KoBeWi added this to the 4.6 milestone Sep 4, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner September 4, 2025 13:42
@KoBeWi KoBeWi requested a review from YeldhamDev September 4, 2025 13:43
@YeldhamDev
Copy link
Member

YeldhamDev commented Sep 4, 2025

Tested and found a couple of problems:

  • The remote node doesn't start selected, even if the inspector shows its info.
  • If the selected node is a child deeper, the inspector still shows nothing.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 5, 2025

Ok I changed the selection check to happen on first tree update after running project.

I noticed that if auto_switch_to_remote_scene_tree is enabled, the remote tree will lose its selection on restart. It does not happen when auto-switch is disabled and you switch to Remote. I don't know if it's something that changed recently, I remember it used to preserve the selection.

Either way, the PR works correctly in cases where the selection stays.

@YeldhamDev
Copy link
Member

The issues have been fixed, thanks.

I noticed that if auto_switch_to_remote_scene_tree is enabled, the remote tree will lose its selection on restart.

Huh, the selection stays on my end.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 5, 2025

Huh, the selection stays on my end.

Maybe it depends on something, idk. Either way it's unrelated.

@Repiteo Repiteo merged commit 22355f2 into godotengine:master Sep 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 24, 2025

Thanks!

@KoBeWi KoBeWi deleted the semote_relect branch September 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote mode problem with dock "Inspector"

3 participants

X Tutup